fix: ignore#655
Open
Zamiell wants to merge 1 commit into
Open
Conversation
|
我看邮件的反应很迟钝。。。如果有事发短信提醒我看邮件。。。。。。
|
Author
|
^ Seems like a spam bot. I reported it to GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again isaac!
Today, I found a type bug in node-glob. The following code results in a type error:
This PR fixes the bug. Note that this change is backwards compatible because in TypeScript, you don't have to do
readonly string[] | string[], becausereadonly string[]is the superset of both these things due to how the type system works.Furthermore, the same issue seems to be present in the codebase in other places:
Do you want me to fix those too?